Revision 4179 - Revision 4191

Revision 4179
Drdrak:

(future revamp) small fix for rare tips crash

Brothel line 998
tip_income += tip[1] -> tip_income += tip[2][1]

Revision 4180

Lillibilli:

(Revamp script)
Partially fixed carpenter, menu works but upgrade timer never goes down at day end.

Revision 4181
Lillibilli:
(Revamp script)
Fixed carpenter to apply the upgrades in a proper manner.
Updated brothel loader to avoid importing nil data for room effects and room decisions.
Added end_day_upgrades method to Game_Brothels class to loop through the brothel and check if upgrades need to be made or timer needs to be lowered. (called from end_day_managing method)

Revision 4182
Drdrak:
(All future revamp)
Consolidated the rxdata exporting functions to a single script file, and renamed the script to Rxdata Export Methods

changed the customer and brothel import code to validate customer class data contained within and store customer_class_ids instead of customer_class_names, also added debugging strings to help identify bad xml.

Changed the load order to load brothels after customer data, so that the customer class array would be built before the brothels are loaded, to facilitate xml import validation (see above), reordered the method definitions as well, to remain consistent.

Renamed the $customer_class[] global to $data_customer_class[] for consistency with other import globals (and adjusted code calls accordingly)

Added the method class_data to the class Customer to facilitate cleaner class data access for any given customer (simply returns $data_customer_class[@class_id])
Used in: add_reputation, which also added some checks to restrict reps to integer values (0..1000)

ALOT of cleaning of code in brothel and other areas

added #todo comments everywhere that I thought something looked fishy or incomplete, for others to confirm and look at, and for ease of final polish run-throughs

Corrected a few methods in brothel to facilitate the new customer_class_id storage paradigm: generate_new_cust_class

corrections to stop_working (actor/couple/party) and remove_girl(actor_id, broNum, force = false) (brothel) to fix the get/store girl at the guild member

corrected the following xml (new import validation fixes)
Pauper.xml
Worker.xml
Traveler.xml
Citizen.xml
Mercenary.xml
Merchant.xml
Craftsman.xml
Politician.xml
Adventurer.xml
Court Jester.xml
Servant.xml
Alien.xml
Yeti.xml
Farmer.xml

All of the brothel xmls

Revision 4183
Drdrak:
corrected a problem with re-use of available name in the brothel and customer imports.

Revision 4184
Drdrak:
removed p command from previous update - woops...

moral of the story, don't code tired :)

Revision 4185
Lillibilli:
(Revamp script)
Removed leftover print command from add_actor method.
Merged ed's bgm loops from the current version.
Options menu doesn't get reset anymore when returning to the title or game over.

Revision 4186
Lillibilli:
(Revamp)
Corrected a few typos in names and descriptions of the brothels.

Revision 4187
Lillibilli:
(Revamp script)
Fixed crash when trying to sell a brothel caused by the @rooms variable clearing.
Commented out uses of $game_variables[5] since they seems to be used by nothing and are updated by old systems that cause crashes.

Revision 4188
Lillibilli:
(Revamp script)
Real Estate menu now properly displays the number of beds a brothel has. (requires restart)
Real Estate menu now lists brothel names instead of locations. (location is still displayed on the right info window)
Shifted the brothel xml loaders methods to be closer together for ease of debugging.

Revision 4189
Drdrak:
(future revamp) minor fix for hanging end caused by commenting vestigial code.

Revision 4190
Lillibilli:
(Revamp script)
Changed Real Estate and Carpenter menus info window behavior to only refresh when index has been changed instead of each frame


Revision 4191
Lillibilli:
(Revamp script)
Fixed end of day log not showing all the owned brothels.
Fixed Communal Windows script dispose methods to check if they are already disposed before disposing the content (caused a rare crash in very specific circumstances).
Fixed class_data method in the Customer class to use the right global variable.
Renamed My Addition script to Time System Moon Phases.